Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

augment single col filter cubes #398

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

ernestoarbitrio
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (33948c7) to head (fff9313).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #398   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         4627      4642   +15     
=========================================
+ Hits          4627      4642   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gergness gergness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only thing I don't get is what _is_single_filter_col_cube means? Is it just an indicator that a set of cubes is from a tabook? Or does it mean something specific about what kind of variables are being used?

@ernestoarbitrio
Copy link
Contributor Author

Looks good, only thing I don't get is what _is_single_filter_col_cube means? Is it just an indicator that a set of cubes is from a tabook? Or does it mean something specific about what kind of variables are being used?

It's a key that the querybuilder adds in the cube response to indicate that that respose is a cube made from a filter cause this needs to be used somewhere in exporter to check some conditions.

@ernestoarbitrio ernestoarbitrio merged commit ec15755 into master Mar 19, 2024
8 checks passed
@ernestoarbitrio ernestoarbitrio deleted the inflate-single-col-filter-cubes-187231707 branch March 19, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants