Enum refactoring 187998654

[ernestoarbitrio]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (56d03c5) to head (2599849).

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #401   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         4750      4756    +6     
=========================================
+ Hits          4750      4756    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gergness]

I don't have strong opinions on this, but not sure why moving the NUMERIC_CUBE_MEASURES out of enums is helpful? To me it feels like the natural place to define collections of measures is in cr.cube.enums, even if some of them are only used in one place.

I lose track of which enum conventions support what, but could it be a property of CUBE_MEASURES or does that only work when we don't subclass enum.Enum?

Again, I don't have strong opinions, so feel free to overrule.

[ernestoarbitrio]

I don't have strong opinions on this, but not sure why moving the NUMERIC_CUBE_MEASURES out of enums is helpful? To me it feels like the natural place to define collections of measures is in cr.cube.enums, even if some of them are only used in one place.

I lose track of which enum conventions support what, but could it be a property of CUBE_MEASURES or does that only work when we don't subclass enum.Enum?

Again, I don't have strong opinions, so feel free to overrule.

agreed done! Thanks