bug fix len vs any #407
Merged
bug fix len vs any #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestoarbitrio
commented
Nov 26, 2024
| @@ -459,8 +459,9 @@ def _subtotal_columns(self): | |||
|
|
|||
| def _subtotal_column(self, subtotal, default): | |||
| """Return (n_rows,) ndarray of values for `subtotal` column.""" | |||
| if self._dimensions[1].dimension_type == DT.CAT_DATE and any( | |||
There was a problem hiding this comment.
any([0]) returns False and this is a bug cause the [0] means we have a subtrahend in the first position.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 4862 4862
=========================================
Hits 4862 4862 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.