Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by value column labels #409

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Sort by value column labels #409

merged 4 commits into from
Dec 12, 2024

Conversation

ernestoarbitrio
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5f1e586) to head (d5bb005).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #409   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         4869      4890   +21     
=========================================
+ Hits          4869      4890   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gergness gergness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but looks good

src/cr/cube/matrix/assembler.py Show resolved Hide resolved
tests/integration/test_cubepart.py Outdated Show resolved Hide resolved
@ernestoarbitrio ernestoarbitrio merged commit d4fc9c8 into master Dec 12, 2024
9 checks passed
@ernestoarbitrio ernestoarbitrio deleted the sort-by-value-col branch December 12, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants