Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling-GotoBtn #19

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

AarinGuleria
Copy link
Contributor

Added a scrolling btn for mobile and web view for ease of traverse from different sections of the website. Below is the demo and updated video for the same changes made in the website.

Demo.mp4

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for d4community failed.

Name Link
🔨 Latest commit 324ab85
🔍 Latest deploy log https://app.netlify.com/sites/d4community/deploys/66a3325fa11241000876b580

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for splendid-manatee-1031ee failed.

Name Link
🔨 Latest commit 324ab85
🔍 Latest deploy log https://app.netlify.com/sites/splendid-manatee-1031ee/deploys/66a3325f63d64200082a2ae6

Information about the particular node version to use for the deployment of the website .
@Sagar0-0
Copy link
Member

it would be better if u can add scroll animation to top instead of current behaviour @AarinGuleria

@Itsayu
Copy link
Contributor

Itsayu commented Jul 25, 2024

it would be better if u can add scroll animation to top instead of current behaviour @AarinGuleria

No problem, we are currently working on the Figma for the new website @Sagar0-0

@AarinGuleria
Copy link
Contributor Author

it would be better if u can add scroll animation to top instead of current behaviour @AarinGuleria

that is added so that if the user is at some different location then he/she can directly go to the top

@Sagar0-0
Copy link
Member

Let the reviewer check and merge
cc: @Itsayu @ayush24k @Ranjeet0302Singh

Copy link
Member

@ayush24k ayush24k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AarinGuleria in src/app.js there are some syntax issues in App component pls fix them

@ayush24k
Copy link
Member

@AarinGuleria in src/app.js there are some syntax issues in App component pls fix them

also we are currently working on completely revamping the d4 website so it will be fine if you leave it as it is!

@AarinGuleria
Copy link
Contributor Author

@AarinGuleria in src/app.js there are some syntax issues in App component pls fix them

Is it about something related to babel.js

@ayush24k
Copy link
Member

ayush24k commented Jul 25, 2024

@AarinGuleria in src/app.js there are some syntax issues in App component pls fix them

Is it about something related to babel.js

no, in src/app.js in app function there is a return inside a return which is causing the build to fail *(at line 27)

@AarinGuleria
Copy link
Contributor Author

AarinGuleria commented Jul 25, 2024

@AarinGuleria in src/app.js there are some syntax issues in App component pls fix them

Is it about something related to babel.js

no, in src/app.js in app function there is a return inside a return which is causing the build to fail *(at line 27)

The error is now resolved.
You can now re check it .
Also I tried it on vercel and was successful build and even deployed.
https://dummy-testing.vercel.app/
here check it i have given the build link also.

@AarinGuleria AarinGuleria requested a review from ayush24k July 25, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants