-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling-GotoBtn #19
base: master
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for d4community failed.
|
❌ Deploy Preview for splendid-manatee-1031ee failed.
|
Information about the particular node version to use for the deployment of the website .
it would be better if u can add scroll animation to top instead of current behaviour @AarinGuleria |
|
that is added so that if the user is at some different location then he/she can directly go to the top |
Let the reviewer check and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AarinGuleria in src/app.js there are some syntax issues in App component pls fix them
also we are currently working on completely revamping the d4 website so it will be fine if you leave it as it is! |
Is it about something related to babel.js |
no, in src/app.js in app function there is a return inside a return which is causing the build to fail *(at line 27) |
The error is now resolved. |
Added a scrolling btn for mobile and web view for ease of traverse from different sections of the website. Below is the demo and updated video for the same changes made in the website.
Demo.mp4