Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix staging deploy github action #3285

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Fix staging deploy github action #3285

merged 3 commits into from
Oct 10, 2024

Conversation

xmunoz
Copy link
Member

@xmunoz xmunoz commented Oct 4, 2024

I rule and have completed some work on Case Manager that's ready for review!

Staging is no longer being autodeployed from main. This is the error message:

/bin/sh: 1: heroku: not found
Created and wrote to ~/.netrc
Successfully logged into heroku
/bin/sh: 1: heroku: not found

This is because heroku no longer comes packaged with the default image of the ubuntu-latest Github-hosted runner (24.04). It was pre-installed on 22.04 however, hence the breakage. They claim to have removed it for "maintenance reasons" 🙄

This PR explicitly installs heroku cli in the staging deploy workflow, and updates the heroku-deploy Github Action to the latest version.

https://devcenter.heroku.com/articles/heroku-cli

@xmunoz xmunoz changed the title Upgrade to latest version of github action Upgrade to latest version of heroku deploy github action Oct 4, 2024
@xmunoz xmunoz requested a review from colinxfleming October 4, 2024 16:02
@xmunoz xmunoz marked this pull request as ready for review October 4, 2024 16:02
@xmunoz
Copy link
Member Author

xmunoz commented Oct 4, 2024

@xmunoz xmunoz changed the title Upgrade to latest version of heroku deploy github action Fix staging deploy github action Oct 4, 2024
@xmunoz xmunoz requested a review from lomky October 7, 2024 13:02
Copy link
Member

@lomky lomky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lomky lomky merged commit 2cbc5f5 into main Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants