feat: title case following The Chicago Manual of Style

DIYgod · Dec 15, 2023 · 7d33c91 · 7d33c91
1 parent fac29ed
commit 7d33c91
Show file tree

Hide file tree

Showing 4 changed files with 142 additions and 10 deletions.
diff --git a/lib/utils/common-utils.js b/lib/utils/common-utils.js
@@ -1,12 +1,8 @@
 const { parseDate } = require('@/utils/parse-date');
+const title = require('title');
 
 // convert a string into title case
-const toTitleCase = (str) =>
-    str
-        .toLowerCase()
-        .split(' ')
-        .map((word) => word.replace(word[0], word[0].toUpperCase()))
-        .join(' ');
+const toTitleCase = (str) => title(str);
 
 const rWhiteSpace = /\s+/;
 const rAllWhiteSpace = /\s+/g;

diff --git a/package.json b/package.json
@@ -144,6 +144,7 @@
     "socks-proxy-agent": "8.0.2",
     "source-map": "0.7.4",
     "tiny-async-pool": "2.1.0",
+    "title": "3.5.3",
     "tough-cookie": "4.1.3",
     "twitter-api-v2": "1.15.2",
     "winston": "3.11.0",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test/utils/common-utils.js b/test/utils/common-utils.js
@@ -2,7 +2,7 @@ const utils = require('../../lib/utils/common-utils');
 
 describe('common-utils', () => {
     it('toTitleCase', () => {
-        expect(utils.toTitleCase('RSSHub IS AS aweSOme aS henry')).toBe('Rsshub Is As Awesome As Henry');
+        expect(utils.toTitleCase('RSSHub IS AS aweSOme aS henry')).toBe('Rsshub Is as Awesome as Henry');
     });
 
     it('convertDateToISO8601', () => {