Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(twitter): only display tweets that contains a media #17310

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

Rakambda
Copy link
Contributor

Involved Issue / 该 PR 相关 Issue

Close #

Example for the Proposed Route(s) / 路由地址示例

/twitter/home
/twitter/likes/DIYgod
/twitter/list/221172095

New RSS Route Checklist / 新 RSS 路由检查表

  • New Route / 新的路由
  • Anti-bot or rate limit / 反爬/频率限制
    • If yes, do your code reflect this sign? / 如果有, 是否有对应的措施?
  • Date and time / 日期和时间
    • Parsed / 可以解析
    • Correct time zone / 时区正确
  • New package added / 添加了新的包
  • Puppeteer

Note / 说明

Add an option to only display tweets that contains a media. Effectively this excludes "text only" tweets, but as the filtering itself is mroe "keep only medias" I prefered to name it that way. I don't know your preferences about it.

Didn't add this option to the user route as there is the media route that basically does the same.
Added info in the params table, though as it isn't added to every route I'm not too sure (though same params in that list are not on all routes anyways).

@github-actions github-actions bot added the Route label Oct 25, 2024
Copy link
Contributor

Successfully generated as following:

http://localhost:1200/twitter/home - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>ConfigNotFoundError: Twitter API is not configured
Route: /twitter/home/:routeParams?
Full Route: /twitter/home
Node Version: v22.10.0
Git Hash: 8693eb4c
http://localhost:1200/twitter/likes/DIYgod - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>ConfigNotFoundError: Twitter API is not configured
Route: /twitter/likes/:id/:routeParams?
Full Route: /twitter/likes/DIYgod
Node Version: v22.10.0
Git Hash: 8693eb4c
http://localhost:1200/twitter/list/221172095 - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>ConfigNotFoundError: Twitter API is not configured
Route: /twitter/list/:id/:routeParams?
Full Route: /twitter/list/221172095
Node Version: v22.10.0
Git Hash: 8693eb4c

@github-actions github-actions bot added the Auto: Route Test Complete Auto route test has finished on given PR label Oct 25, 2024
lib/routes/twitter/utils.ts Outdated Show resolved Hide resolved
lib/routes/twitter/home-latest.ts Outdated Show resolved Hide resolved
Co-authored-by: Tony <TonyRL@users.noreply.github.com>
Copy link
Contributor

Successfully generated as following:

http://localhost:1200/twitter/home - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>ConfigNotFoundError: Twitter API is not configured
Route: /twitter/home/:routeParams?
Full Route: /twitter/home
Node Version: v22.10.0
Git Hash: aca971e7
http://localhost:1200/twitter/likes/DIYgod - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>ConfigNotFoundError: Twitter API is not configured
Route: /twitter/likes/:id/:routeParams?
Full Route: /twitter/likes/DIYgod
Node Version: v22.10.0
Git Hash: aca971e7
http://localhost:1200/twitter/list/221172095 - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>ConfigNotFoundError: Twitter API is not configured
Route: /twitter/list/:id/:routeParams?
Full Route: /twitter/list/221172095
Node Version: v22.10.0
Git Hash: aca971e7

@Rakambda Rakambda force-pushed the feat/twitter-only-media branch from 3e723a0 to 8c5946b Compare October 26, 2024 16:47
@Rakambda Rakambda requested a review from TonyRL October 26, 2024 16:49
Copy link
Contributor

Successfully generated as following:

http://localhost:1200/twitter/home - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>ConfigNotFoundError: Twitter API is not configured
Route: /twitter/home/:routeParams?
Full Route: /twitter/home
Node Version: v22.10.0
Git Hash: 3780cc63
http://localhost:1200/twitter/likes/DIYgod - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>ConfigNotFoundError: Twitter API is not configured
Route: /twitter/likes/:id/:routeParams?
Full Route: /twitter/likes/DIYgod
Node Version: v22.10.0
Git Hash: 3780cc63
http://localhost:1200/twitter/list/221172095 - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>ConfigNotFoundError: Twitter API is not configured
Route: /twitter/list/:id/:routeParams?
Full Route: /twitter/list/221172095
Node Version: v22.10.0
Git Hash: 3780cc63

@TonyRL TonyRL merged commit a71410f into DIYgod:master Oct 26, 2024
27 checks passed
@Rakambda Rakambda deleted the feat/twitter-only-media branch October 26, 2024 19:07
artefaritaKuniklo pushed a commit to artefaritaKuniklo/RSSHub that referenced this pull request Dec 13, 2024
* feat: only display tweets that contains a media

* Use lambda to simplify filtering

* wording: media is uncountable

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto: Route Test Complete Auto route test has finished on given PR Route
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants