Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify variables to be set #159

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Simplify variables to be set #159

merged 1 commit into from
Aug 25, 2024

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Aug 16, 2024

We use the MySQL replication and keepalived together, if we ever have a usecase where we want to replicate the database and IP in a different way we can set that later.

I think even for the setup:

dj-primary: desktop
dj-second: desktop
dj-emerg: laptop

we would still prefer 1 variable and just not set the priority for dj-emerg so that it wouldn't start keepalived but would be setup with replication.

We use the MySQL replication and keepalived together, if we ever have a
usecase where we want to replicate the database and IP in a different
way we can set that later.
@eldering
Copy link
Member

I don't understand how this is simplifying things. There's no duplicate variable removed, is there?

@vmcj
Copy link
Member Author

vmcj commented Aug 16, 2024

I don't understand how this is simplifying things. There's no duplicate variable removed, is there?

I would say there is, we have both:
REPLICATION_INTERFACE used for MySQL replication and KEEPALIVED_INTERFACE used for keepalived,

The only real moments where we need those are when we test on calc{a,b} as there we have multiple interfaces, in all other situations we tend to have only 1 interface in use. The scripts did now fail as both were not documented, and I don't see a real reason to have the distinction in practice.

@vmcj vmcj merged commit 9adfd25 into DOMjudge:main Aug 25, 2024
3 checks passed
@vmcj vmcj deleted the repl_double_var branch August 25, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants