New layout #6
Merged
New layout #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you don't want to commit pycache directories |
blackary
reviewed
Feb 15, 2023
blackary
reviewed
Feb 15, 2023
blackary
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Seems like a fine set of changes overall. A few decisions that wouldn't be my favorite:
- I do like automagic calver, but doing it manually is certainly simpler
- I'd put the gitignore back
- I do prefer putting source code in
src/to make it harder to accidentally import the local module, rather than the package, when testing the package
But, none of those seem like a big deal, and there are some significant wins here, so seems fine to me overall.
blackary
reviewed
Feb 15, 2023
requirements.txt
Outdated
| intake | ||
| s3fs | ||
| msgpack | ||
| requests |
There was a problem hiding this comment.
Any idea why we need this, when we don't use it explicitly in the codebase?
There was a problem hiding this comment.
intake/intake#706
if Martin does another intake release we can remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new layout: moves tests to root folder, rm setup.py and use pyproject.toml
use latest s3fs moto patch from aio-libs/aiobotocore#755 (comment)
added a KeyError(f"{urlpah}")
fixed a mypy complain with https://github.com/hauntsaninja/no_implicit_optional