Remove casts

DTS-STN · Dec 17, 2024 · 9010680 · 9010680
1 parent af36e9f
commit 9010680
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 22 deletions.
diff --git a/pages/decision-reviews.tsx b/pages/decision-reviews.tsx
@@ -186,15 +186,19 @@ export async function getServerSideProps({
   const logger = getLogger('decision-reviews')
   logger.level = 'error'
 
-  const content = await getDecisionReviewsContent().catch((error) => {
-    logger.error(error)
-    return { err: '500' } as DecisionReviewContent
-  })
+  const content = await getDecisionReviewsContent().catch(
+    (error): DecisionReviewContent => {
+      logger.error(error)
+      return { err: '500' }
+    },
+  )
 
-  const authModals = await getAuthModalsContent().catch((error) => {
-    logger.error(error)
-    return { err: '500' } as AuthModalsContent
-  })
+  const authModals = await getAuthModalsContent().catch(
+    (error): AuthModalsContent => {
+      logger.error(error)
+      return { err: '500' }
+    },
+  )
 
   /* istanbul ignore next */
   const langToggleLink =

diff --git a/pages/profile.tsx b/pages/profile.tsx
@@ -177,15 +177,17 @@ export async function getServerSideProps({
   const logger = getLogger('profile')
   logger.level = 'error'
 
-  const content = await getProfileContent().catch((error) => {
+  const content = await getProfileContent().catch((error): ProfileContent => {
     logger.error(error)
-    return { err: '500' } as ProfileContent
+    return { err: '500' }
   })
 
-  const authModals = await getAuthModalsContent().catch((error) => {
-    logger.error(error)
-    return { err: '500' } as AuthModalsContent
-  })
+  const authModals = await getAuthModalsContent().catch(
+    (error): AuthModalsContent => {
+      logger.error(error)
+      return { err: '500' }
+    },
+  )
 
   /* istanbul ignore next */
   const langToggleLink = locale === 'en' ? '/fr/profil' : '/en/profile'

diff --git a/pages/security-settings.tsx b/pages/security-settings.tsx
@@ -154,15 +154,19 @@ export async function getServerSideProps({
   const logger = getLogger('security-settings')
   logger.level = 'error'
 
-  const content = await getSecuritySettingsContent().catch((error) => {
-    logger.error(error)
-    return { err: '500' } as SecuritySettingsContent
-  })
+  const content = await getSecuritySettingsContent().catch(
+    (error): SecuritySettingsContent => {
+      logger.error(error)
+      return { err: '500' }
+    },
+  )
 
-  const authModals = await getAuthModalsContent().catch((error) => {
-    logger.error(error)
-    return { err: '500' } as AuthModalsContent
-  })
+  const authModals = await getAuthModalsContent().catch(
+    (error): AuthModalsContent => {
+      logger.error(error)
+      return { err: '500' }
+    },
+  )
 
   /* istanbul ignore next */
   const langToggleLink =