Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Tracing to Middleware #421

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Adding Tracing to Middleware #421

merged 6 commits into from
Nov 7, 2023

Conversation

lhr-git
Copy link
Contributor

@lhr-git lhr-git commented Oct 31, 2023

ADO-141267

Description of proposed changes:

  • Adding tracing into the mw via instrumentation
  • removing the automated sdk method via tracing.js
  • removing tracing.js
  • Added supporting ENV var to example

What to test for/How to test

  • you would need to setup a tracing stack of some sort that supported open telemetry (Grafana/tempo is probably the easiest)

Additional Notes

  • for setting up on dynatrace you can see Senor's Journey or our Next-Template, but basically you just need to add in the ENV vars with the OTEL API KEY and the endpoints for metrics and tracing. SJ has a working example of both.

@lhr-git lhr-git requested a review from a team as a code owner October 31, 2023 19:02
@github-actions GitHub Actions
Copy link

Integration Deployment 🚀 - Build Status
Default Tests Workflow Status
Jest Coverage Report
Cypress Coverage Report

krischarbonneau
krischarbonneau approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@krischarbonneau krischarbonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhr-git lhr-git merged commit c7a2ce7 into dev Nov 7, 2023
7 checks passed
@lhr-git lhr-git deleted the lharrison-tracing-mw branch November 7, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krischarbonneau krischarbonneau krischarbonneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhr-git @krischarbonneau