Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert security settings and decision review to typescript #781

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

Charles-Pham
Copy link
Contributor

ADO-275722

Changelog - "fix:" for bug fixes, "feat:" for features. Read more about Conventional Commits at https://www.conventionalcommits.org/en/v1.0.0/#summary

Description of proposed changes:

Convert security settings and decision review to typescript. Also make buttons type an optional onClick with the default doing nothing.

What to test for/How to test

No changes should be visible to end users

Additional Notes

@Charles-Pham Charles-Pham requested a review from a team as a code owner December 16, 2024 19:37
Copy link

Copy link
Contributor

@susan-esdc susan-esdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine. I guess lint did something again with commas, but nothing destructive

@Charles-Pham Charles-Pham merged commit 19b0e58 into dev Dec 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants