Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CoinAPI for libPiggyEconomy #11

Closed
wants to merge 2 commits into from

Conversation

ClickedTran
Copy link

@ClickedTran ClickedTran commented Nov 14, 2023

  • Add new provider, that is CoinAPI, I see many people are quite disappointed when my plugin uses libPiggyEconomy because it does not support CoinAPI, and most people see CoinAPI as a plugin that helps them make money by recharging the server.
  • Please accept this pull request

Thank Author and Development Team for reading and accept

Written by: ClickedTran
Once again thank you all

@Aericio Aericio requested a review from DaPigGuy November 14, 2023 10:12
@Aericio
Copy link
Collaborator

Aericio commented Nov 14, 2023

Where is the repository for CoinAPI?

@ClickedTran
Copy link
Author

Kho lưu trữ của CoinAPI ở đâu?

I'm not sure, CoinAPI is a remade plugin based on EconomyAPI, but I see a lot of people are interested in it, you can see it here: https://youtu.be/qDn9Ca72-Zk?si=mhhb8PIaPZktwZip

@Aericio
Copy link
Collaborator

Aericio commented Nov 14, 2023

Unfortunately, since the code isn't available on GitHub nor Poggit, I won't be accepting this PR for safety reasons. I don't want to bring exposure to a potentially unsafe plugin.

You can ask the maintainer of CoinAPI to upload their code on GitHub/Poggit, then we can take a look at adding support again.

Thank you for your contribution, though.

@Aericio Aericio closed this Nov 14, 2023
@Aericio Aericio removed the request for review from DaPigGuy November 14, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants