GRIDEDIT-953 FIxed several sonarcloud warnings

Deltares · Jun 18, 2024 · 05edc2f · 05edc2f
1 parent 8d86872
commit 05edc2f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/libs/MeshKernel/include/MeshKernel/Operations.hpp b/libs/MeshKernel/include/MeshKernel/Operations.hpp
@@ -486,20 +486,16 @@ namespace meshkernel
 
         if (pointAdimensionalCoordinate - coordinate < eps)
         {
-            return pointCoordinate = coordinates.at(static_cast<UInt>(coordinate));
-            // return pointCoordinate = coordinates[static_cast<UInt>(coordinate)];
+            return pointCoordinate = coordinates[static_cast<UInt>(coordinate)];
         }
 
         const UInt low = static_cast<UInt>(coordinate);
         const UInt high = low + 1;
         const double a = high - pointAdimensionalCoordinate;
         const double b = pointAdimensionalCoordinate - low;
 
-        pointCoordinate = coordinates.at(low) * a + coordinates.at(high) * b +
-                          (coordinatesDerivatives.at(low) * (pow(a, 3) - a) + coordinatesDerivatives.at(high) * (pow(b, 3) - b)) / 6.0 * splFac;
-
-        // pointCoordinate = coordinates[low] * a + coordinates[high] * b +
-        //                   (coordinatesDerivatives[low] * (pow(a, 3) - a) + coordinatesDerivatives[high] * (pow(b, 3) - b)) / 6.0 * splFac;
+        pointCoordinate = coordinates[low] * a + coordinates[high] * b +
+                          (coordinatesDerivatives[low] * (pow(a, 3) - a) + coordinatesDerivatives[high] * (pow(b, 3) - b)) / 6.0 * splFac;
 
         return pointCoordinate;
     }

diff --git a/libs/MeshKernel/tests/src/SplineTests.cpp b/libs/MeshKernel/tests/src/SplineTests.cpp
@@ -209,6 +209,4 @@ TEST(Splines, SplineMultiIntersection)
     bool crossing = splines.GetSplinesIntersection(0, 1, crossProductIntersection, dimensionalIntersection, firstSplineRatio, secondSplineRatio);
 
     ASSERT_TRUE(crossing);
-
-    // const double tolerance = 1e-6;
 }