Optimize wasm bindgen asset with manganis #3531
Open
+980
−1,107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
bug
ealmloff
commented
Jan 9, 2025
| @@ -7,7 +7,7 @@ description = "CLI for building fullstack web, desktop, and mobile apps with a s | |||
| repository = "https://github.com/DioxusLabs/dioxus/" | |||
| license = "MIT OR Apache-2.0" | |||
| keywords = ["mobile", "gui", "cli", "dioxus", "wasm"] | |||
| rust-version = "1.79.0" | |||
| rust-version = "1.81.0" | |||
There was a problem hiding this comment.
swc requires a newer version of rust to build. I'm not sure how much we care about the rust version the CLI requires since we are leaning into binstall everywhere, but if this an issue I could look for alternatives
ealmloff
changed the title
|
Marking this as a draft until we find the latest version of swc settings that are compatible with a broader set of javascript like #3539 |
ealmloff
commented
Jan 13, 2025
|
This PR also fixes a few caching issues with manganis/the CLI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the manganis bundling system to hash and optimize the assets wasm bindgen generates. It also expands cli-opt to support bundling multiple js files together which is useful for the javascript files wasm bindgen outputs.
Requests for hello world app with old version of DX:
Requests for hello world app with new version of DX:
Closes #3350
Closes #3339
Closes #3278
Closes #3277
Closes #2124