Fix initialising tray icons on the macos desktop platform #3533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on multiple versions of the
muda
crate - one directly and one via a transitive dependency in the tray-icon crate - leads to the following error when attempting to initialize a tray icon on the desktop platform, specifically on MacOS:Without any prior knowledge on how the
muda
crate or MacOS tray icons work, it appears thatmuda
generates some sort of class definition for MacOS whose identifier needs to be unique. Multiple versions of the crate will then lead to duplicate definitions and thereby the above crash at runtime.Since this only breaks at runtime and only on the MacOS target it's far from trivial to add a test to ensure this doesn't break again on the next
cargo update
. I'll open a related ticket in the muda repository, maybe they can think of a more robust solution.