Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of MULTILEADER and MULTILEADERSTYLE #169

Merged
merged 30 commits into from
Nov 3, 2023
Merged

Implementation of MULTILEADER and MULTILEADERSTYLE #169

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
43614d7
Implement Multileader
Sep 15, 2023
4d25097
Merge pull request #5 from mme1950/20230915_mme_Multileader
nka1994 Sep 15, 2023
15b59ba
Update Multileader Summary and DwgMergedReader Advance Method
Sep 29, 2023
b93c5b4
Update from Original Repository
Sep 29, 2023
24b4f8f
Draw Multileader to sample_AC1032.dwg
Oct 4, 2023
1e827f7
Improve Clone Function for Multileader
Oct 4, 2023
24fc426
Styles do not need to be cloned
Oct 4, 2023
06f7112
- some refactoring
Oct 4, 2023
1bd0fe8
Change Arrowhead Data Type for BlockRecord
Oct 4, 2023
68d8ed0
Replace BlockRecord with ContentsBlock
Oct 4, 2023
318a9f6
Add SubclassMarker for Multileader
Oct 4, 2023
ec01a04
Add SubclassMarker for MLeaderStyle
Oct 4, 2023
ca176e4
Add Constructor for MultiLeaderStyle
Oct 4, 2023
0f36506
Add Constructor for MultiLeaderAnnotContext and Clone BlockAttributes…
Oct 4, 2023
99e190f
Implement Missing Clone Methods
Oct 4, 2023
d14b04e
Merge branch 'master' into master
nka1994 Oct 10, 2023
38987f9
Improve MultiLeader
Oct 16, 2023
5d48490
Correct After Review
Oct 16, 2023
b729831
Merge branch 'master' into master
nka1994 Oct 30, 2023
8e1a0e6
Corrections
Oct 30, 2023
8c2b328
Fix MultiLeader Clone
Oct 31, 2023
b1ded16
Add MultiLeader Sample DWG
Oct 31, 2023
b6c5987
Implement Asserts for MultiLeader
Oct 31, 2023
ac6fa2d
Corrections
Nov 3, 2023
759b778
Fix Color Tests and Add MultiLeader to Ignore List
Nov 3, 2023
9a63d0b
Update Comments
Nov 3, 2023
b3f82d2
- comments improved
Nov 3, 2023
50f57b6
Baseline Merge, Comments Improved
Nov 3, 2023
e60a94a
Fix DwgObjectReader
Nov 3, 2023
f5fb8e0
Update MultiLeader.cs
DomCR Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ACadSharp/Entities/MultiLeader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,6 @@ public override CadObject Clone()
{
MultiLeader clone = (MultiLeader)base.Clone();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are elements in this object that need to be cloned separately, for an example you can check how the type Entity handles the cloning method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK


clone.Style = (MultiLeaderStyle)this.Style?.Clone();
clone.LineType = (LineType)this.LineType?.Clone();
clone.TextStyle = (TextStyle)this.TextStyle?.Clone();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be cloned, otherwise the styles won't be detached form the document.


return clone;
}
}
Expand Down