Replace double[] with Matrix4 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJGosnell
suggested changes
Nov 17, 2023
| elements[14] = _objectReader.ReadBitDouble(); | ||
| elements[15] = _objectReader.ReadBitDouble(); | ||
|
|
||
| annotContext.TransformationMatrix = new Matrix4(elements); |
There was a problem hiding this comment.
It would significantly reduce memory impact here (128 bytes for a double[16] per each object read) if you used the Matrix4 constructor below.
This is an an issue especially in this hot path because the double[] is just discarded anyway.
public Matrix4( double m00, double m10, double m20, double m30, double m01, double m11, double m21, double m31, double m02, double m12, double m22, double m32, double m03, double m13, double m23, double m33)
DomCR
approved these changes
Nov 20, 2023
|
Looks good! great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Short description about this PR
Tasks done in this PR
Related Issues / Pull Requests
Notes for reviewer