-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#230 fixed #243
#230 fixed #243
Conversation
mme1950
commented
Jan 6, 2024
- Leader: new property AssociatedAnnotation
- CadLeaderTemplate: implementation added: Build
- CadLeaderTemplaate: implementation added: Build
} | ||
if (builder.TryGetCadObject(this.AnnotationHandle, out Entity annotation)) { | ||
leader.AssociatedAnnotation = annotation; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The annotation is always present? if it is, it would be good to have an else with a log using the notification method so the user knows why the annotation is missing when the reader finishes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you provided the getTableReference
method for table references. Shoud we implement a similar method for Entity references?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure but I think that some entity references may have a null value, so I'm not sure that this method needs to be implemented, that's why I'm asking if the AssociatedAnnotation can be null or not, because if it can, there is no need to notify anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I do not know. I suppose it is null when no annotation is associated with the leader.
I currently cannot check in AutoCAD, whether it is possible to create a LEADER without annotation.
The annotation (typically an MTEXT) of a LEADER appears as a separate object in the DWG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... because if it can, there is no need to notify anything.
I thought the notification is issued when a reference was read that cannot be resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, that's why I've asked if this parameter is optional, because if it is, not finding the value or assigning a null value is a valid resolution for the reference and should not be notified as an error or warning.
We checked it with AutoCAD: |
Perfect! merging this PR. Good work!! |