Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 9 #56

Merged
merged 10 commits into from
Mar 6, 2024
Merged

Fix/issue 9 #56

merged 10 commits into from
Mar 6, 2024

Conversation

omibo
Copy link
Collaborator

@omibo omibo commented Mar 5, 2024

I have documented the code in lib.rs related to the SHA3 function.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@Dustin-Ray
Copy link
Owner

thanks for the awesome docs! this helps make the library more readable and maintainable. very grateful for your help. please resolve the above items and we can merge this in.

@omibo
Copy link
Collaborator Author

omibo commented Mar 6, 2024

Issues are resolved. Thanks for helpful comments.

Copy link
Owner

@Dustin-Ray Dustin-Ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for helping to increase the readability and usability of the library. Nicely done! You are free to merge to main whenever you see fit

@omibo omibo requested a review from Dustin-Ray March 6, 2024 04:08
@omibo
Copy link
Collaborator Author

omibo commented Mar 6, 2024

Apparently I do not have write access and cannot merge to main.

@Dustin-Ray Dustin-Ray merged commit 16193bc into Dustin-Ray:main Mar 6, 2024
1 check passed
@Dustin-Ray
Copy link
Owner

merged! thanks for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants