Cherry-pick PRs 14394, 14424, 14500, 14740 (#15032)

* DYN-6527: Fix graph update for primitive input nodes that are first initialized to null  (#14703)

* remove coreclr-ncalc references

* add failing test for dropdown node

* cleanup

* update tests

* attempt initial fix

* cleanup

* update test

* review comments

* add code comments

* cherry-pick PR 14637

* cherry-pick PR 14394

* cherry-pick PR 14740

* Fix for element binding messagebox display on saveas (#14424)

* remove coreclr-ncalc references

* fix for element binding messagebox on saveas

* cherry pick PRs 14424, 14500

* build fix

---------

Co-authored-by: Michael Kirschner <mjk.kirschner@gmail.com>

src/DynamoCoreWpf/Properties/Resources.en-US.resx

@@ -3651,4 +3651,13 @@ In certain complex graphs or host program scenarios, Automatic mode may cause in
   <data name="PreferencesViewIncludeTimestampExportPathTooltip" xml:space="preserve">
     <value>When toggled on, file names of exported images include date and time of export.</value>
   </data>
-</root>
+  <data name="ElementBindingWarningMessage" xml:space="preserve">
+    <value>A Save As command will create a workspace which is treated as a completely new file by Dynamo and existing element binding data will be lost. New element binding data will be created as normal as you run this file. Use the Save command instead if you wish to preserve element binding with the host document.</value>
+  </data>
+  <data name="ElementBindingWarningTitle" xml:space="preserve">
+    <value>Element Binding Warning</value>
+  </data>
+  <data name="ElementBindingDesc" xml:space="preserve">
+    <value>Element Binding allows a two-way interaction between Dynamo and the host application like Revit or Civil3D where a user can select an element in the host document and have Dynamo "bind" that element to a node in the workspace.</value>
+  </data>
+</root>

src/DynamoCoreWpf/Properties/Resources.resx

@@ -3638,4 +3638,13 @@ In certain complex graphs or host program scenarios, Automatic mode may cause in
   <data name="PreferencesViewIncludeTimestampExportPathTooltip" xml:space="preserve">
     <value>When toggled on, file names of exported images include date and time of export.</value>
   </data>
-</root>
+  <data name="ElementBindingWarningMessage" xml:space="preserve">
+    <value>A Save As command will create a workspace which is treated as a completely new file by Dynamo and existing element binding data will be lost. New element binding data will be created as normal as you run this file. Use the Save command instead if you wish to preserve element binding with the host document.</value>
+  </data>
+  <data name="ElementBindingWarningTitle" xml:space="preserve">
+    <value>Element Binding Warning</value>
+  </data>
+  <data name="ElementBindingDesc" xml:space="preserve">
+    <value>Element Binding allows a two-way interaction between Dynamo and the host application like Revit or Civil3D where a user can select an element in the host document and have Dynamo "bind" that element to a node in the workspace.</value>
+  </data>
+</root>

src/DynamoCoreWpf/UI/Prompts/DynamoMessageBox.xaml

@@ -4,7 +4,7 @@
         xmlns:p="clr-namespace:Dynamo.Wpf.Properties;assembly=DynamoCoreWpf"
         xmlns:ui="clr-namespace:Dynamo.UI"
         xmlns:localui="clr-namespace:Dynamo.Wpf.UI.GuidedTour"
-        xmlns:w="clr-namespace:System.Windows;assembly=PresentationCore"
+        xmlns:fa="http://schemas.fontawesome.io/icons/"
         Title="{x:Static p:Resources.GenericTaskDialogTitle}"
         MinWidth="400"
         MaxWidth="500"
@@ -98,6 +98,35 @@
                                Foreground="#3C3C3C"
                                Text="{Binding TitleText, UpdateSourceTrigger=PropertyChanged}"
                                TextWrapping="Wrap" />
+                    <Label HorizontalAlignment="Right" 
+                           Name="TooltipInfo"
+                           VerticalAlignment="Center" 
+                           Height="26" 
+                           Width="53" 
+                           Margin="20 -3 0 0">
+                        <Label.Style>
+                            <Style TargetType="{x:Type Label}">
+                                <Setter Property="Visibility" Value="Collapsed" />
+                                <Style.Triggers>
+                                    <DataTrigger Binding="{Binding ShowTooltip}" Value="True">
+                                        <Setter Property="Visibility" Value="Visible" />
+                                    </DataTrigger>
+                                </Style.Triggers>
+                            </Style>
+                        </Label.Style>
+                        <Label.ToolTip>
+                            <ToolTip Content="{Binding Path=Tooltip}" 
+                                     Style="{StaticResource GenericToolTipLight}"/>
+                        </Label.ToolTip>
+                        <Label.Content>
+                            <fa:ImageAwesome Width="15" 
+                                             Height="15" 
+                                             VerticalAlignment="Bottom" 
+                                             HorizontalAlignment="Left" 
+                                             Icon="QuestionCircle"                                               
+                                             Foreground="#808080"/>
+                        </Label.Content>
+                    </Label>
                 </DockPanel>
                 <Rectangle Name="Separator"
                            Grid.Row="0"

src/DynamoCoreWpf/UI/Prompts/DynamoMessageBox.xaml.cs

@@ -88,6 +88,18 @@ public MessageBoxImage MessageBoxImage
             }
         }
 
+        /// <summary>
+        /// A tooltip is shown on the message box when this is set to true and if
+        /// Tooltip is non-null and non-empty.  
+        /// </summary>
+        public bool ShowTooltip { get; private set; }
+
+        /// <summary>
+        /// A tooltip is shown on the message box when this is set to a non-empty string
+        /// and ShowTooltip is true.
+        /// </summary>
+        public string Tooltip { get; private set; }
+
         #endregion
 
         /// <summary>
@@ -97,6 +109,8 @@ public DynamoMessageBox()
         {
             InitializeComponent();
             DataContext = this;
+            ShowTooltip = false;
+            ToolTip = "";
         }
 
         /// <summary>
@@ -106,16 +120,19 @@ public DynamoMessageBox()
         /// <param name="caption"></param>
         /// <param name="button"></param>
         /// <param name="icon"></param>
+        /// <param name="tooltip"></param>
         /// <returns></returns>
         public static MessageBoxResult Show(string messageBoxText, string caption, MessageBoxButton button,
-            MessageBoxImage icon)
+            MessageBoxImage icon, string tooltip = "")
         {
             var dynamoMessageBox = new DynamoMessageBox
             {
                 BodyText = messageBoxText,
                 TitleText = caption,
                 MessageBoxButton = button,
-                MessageBoxImage = icon
+                MessageBoxImage = icon,
+                ShowTooltip = !string.IsNullOrEmpty(tooltip),
+                Tooltip = tooltip
             };
 
             dynamoMessageBox.ConfigureButtons(button);

src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs

@@ -2087,10 +2087,13 @@ private void InternalSaveAs(string path, SaveContext saveContext, bool isBackup
         {
             try
             {
-                Model.Logger.Log(String.Format(Properties.Resources.SavingInProgress, path));
-                CurrentSpaceViewModel.Save(path, isBackup, Model.EngineController, saveContext);
+                Model.Logger.Log(string.Format(Properties.Resources.SavingInProgress, path));
+                var hasSaved = CurrentSpaceViewModel.Save(path, isBackup, Model.EngineController, saveContext);
 
-                if (!isBackup) AddToRecentFiles(path);
+                if (!isBackup && hasSaved)
+                {
+                    AddToRecentFiles(path);
+                }                                    
             }
             catch (Exception ex)
             {
@@ -2151,8 +2154,10 @@ internal void SaveAs(Guid id, string path, bool isBackup = false, SaveContext sa
             try
             {
                 Model.Logger.Log(String.Format(Properties.Resources.SavingInProgress, path));
-                Workspaces.Where(w => w.Model.Guid == id).FirstOrDefault().Save(path, isBackup, Model.EngineController, saveContext);
-                if (!isBackup) AddToRecentFiles(path);
+                var hasSaved = Workspaces.FirstOrDefault(w => w.Model.Guid == id).Save(
+                    path, isBackup, Model.EngineController, saveContext);
+
+                if (!isBackup && hasSaved) AddToRecentFiles(path);
             }
             catch (Exception ex)
             {

src/DynamoCoreWpf/ViewModels/Core/WorkspaceViewModel.cs

@@ -20,6 +20,7 @@
 using Dynamo.Graph.Workspaces;
 using Dynamo.Models;
 using Dynamo.Selection;
+using Dynamo.UI.Prompts;
 using Dynamo.Utilities;
 using Dynamo.Wpf.ViewModels;
 using Dynamo.Wpf.ViewModels.Core;
@@ -598,7 +599,7 @@ internal void ZoomOutInternal()
         /// <param name="engine"></param>
         /// <param name="saveContext"></param>
         /// <exception cref="ArgumentNullException">Thrown when the file path is null.</exception>
-        internal void Save(string filePath, bool isBackup = false, EngineController engine = null, SaveContext saveContext = SaveContext.None)
+        internal bool Save(string filePath, bool isBackup = false, EngineController engine = null, SaveContext saveContext = SaveContext.None)
         {
             if (String.IsNullOrEmpty(filePath))
             {
@@ -627,6 +628,23 @@ internal void Save(string filePath, bool isBackup = false, EngineController engi
                 {
                     // For intentional SaveAs either through UI or API calls, replace workspace elements' Guids and workspace Id
                     jo["Uuid"] = Guid.NewGuid().ToString();
+                    if (jo["Bindings"] != null && jo["Bindings"].Any())
+                    {
+                        jo["Bindings"] = JToken.Parse("[]");
+
+                        if (!DynamoModel.IsTestMode)
+                        {
+                            var result = DynamoMessageBox.Show(Wpf.Properties.Resources.ElementBindingWarningMessage,
+                                Wpf.Properties.Resources.ElementBindingWarningTitle, MessageBoxButton.OKCancel,
+                                MessageBoxImage.Warning, Wpf.Properties.Resources.ElementBindingDesc);
+
+                            if (result == MessageBoxResult.Cancel)
+                            {
+                                return false;
+                            }
+                        }
+                    }
+
                     saveContent = GuidUtility.UpdateWorkspaceGUIDs(jo.ToString());
                 }
                 else
@@ -656,6 +674,8 @@ internal void Save(string filePath, bool isBackup = false, EngineController engi
                 Debug.WriteLine(ex.Message + " : " + ex.StackTrace);
                 throw (ex);
             }
+
+            return true;
         }
         /// <summary>
         /// This function appends view block to the model json

test/DynamoCoreWpfTests/DynamoViewTests.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Globalization;
@@ -21,6 +22,7 @@
 using Dynamo.Wpf.ViewModels.Core;
 using Dynamo.Wpf.Views;
 using DynamoCoreWpfTests.Utility;
+using Newtonsoft.Json.Linq;
 using NUnit.Framework;
 using SharpDX.DXGI;
 
@@ -126,6 +128,49 @@ public void OpeningWorkspaceWithTclsrustWarning()
             DynamoModel.IsTestMode = true;
         }
 
+        [Test]
+        public void ElementBinding_SaveAs()
+        {
+            var prebindingPathInTestDir = @"core\callsite\trace_test-prebinding.dyn";
+            var prebindingPath = Path.Combine(GetTestDirectory(ExecutingDirectory), prebindingPathInTestDir);
+
+            var pathInTestsDir = @"core\callsite\trace_test.dyn";
+            var filePath = Path.Combine(GetTestDirectory(ExecutingDirectory), pathInTestsDir);
+
+            // Always start with a fresh workspace with no binding data for this test.
+            File.Copy(prebindingPath, filePath);
+            OpenAndRun(pathInTestsDir);
+
+            // Assert that the node doesn't have trace data the first time it's run.
+            var hasTraceData = Model.CurrentWorkspace.Nodes.FirstOrDefault(x =>
+                x.Name == "IncrementerTracedClass.WasCreatedWithTrace");
+            Assert.AreEqual(false, hasTraceData.CachedValue.Data);
+
+            // Saving the workspace after a run serializes trace data to the DYN.
+            ViewModel.SaveCommand.Execute(null);
+
+            DynamoUtilities.PathHelper.isValidJson(filePath, out string fileContents, out Exception ex);
+            var obj = DSCore.Data.ParseJSON(fileContents) as Dictionary<string, object>;
+            Assert.AreEqual(1, (obj["Bindings"] as IEnumerable<object>).Count());
+
+            var saveAsPathInTestDir = @"core\callsite\trace_test2.dyn";
+            var saveAsPath = Path.Combine(GetTestDirectory(ExecutingDirectory), saveAsPathInTestDir);
+
+            // SaveAs current workspace, close workspace.
+            ViewModel.SaveAsCommand.Execute(saveAsPath);
+            ViewModel.CloseHomeWorkspaceCommand.Execute(null);
+
+            Open(saveAsPathInTestDir);
+
+            // Assert saved as file doesn't have binding data after open.
+            DynamoUtilities.PathHelper.isValidJson(saveAsPath, out fileContents, out ex);
+            obj = DSCore.Data.ParseJSON(fileContents) as Dictionary<string, object>;
+            Assert.AreEqual(0, (obj["Bindings"] as IEnumerable<object>).Count());
+
+            File.Delete(filePath);
+            File.Delete(saveAsPath);
+        }
+
         [Test]
         public void TestToastNotificationClosingBehavior()
         {