Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6303 Update docs for ColorRange node #14472

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

avidit
Copy link
Contributor

@avidit avidit commented Oct 6, 2023

Purpose

Update docs for ColorRange node

  • fix typo
  • update graph

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@avidit avidit requested a review from QilongTang October 6, 2023 18:46
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

":white_check_mark: Bin-Diff Issue Resolved."
(Updated: 2023-10-20-13:35:25)

@QilongTang
Copy link
Contributor

LGTM, bear in mind that these stored documentations are created from Dynamo Dictionary repo so we need to think about how to reflect changes back there or obsolete it sometime soon.

@QilongTang QilongTang added this to the 3.0 milestone Oct 11, 2023
@QilongTang
Copy link
Contributor

QilongTang commented Oct 11, 2023

Also, I am not sure about the logs removed in this PR, when were they introduced? According to https://autodesk.slack.com/archives/C0S1Q4NSJ/p1696995176201629, there are integrators depending on it. Should we consider moving this file to shared folder as well? @sm6srw

Please do not merge yet before we make a decision

@QilongTang QilongTang added the DNM Do not merge. For PRs. label Oct 11, 2023
@avidit
Copy link
Contributor Author

avidit commented Oct 20, 2023

@QilongTang I have updated the PR to not delete the log files as integrators are depending upon it. I will create a follow up task to move such files into shared doc folder.

@QilongTang QilongTang removed the DNM Do not merge. For PRs. label Oct 20, 2023
@QilongTang QilongTang merged commit 4fd6866 into DynamoDS:master Oct 20, 2023
17 checks passed
@avidit avidit deleted the feature/DYN-6303 branch October 23, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants