Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6292 Upload artifact after build #14482

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

avidit
Copy link
Contributor

@avidit avidit commented Oct 12, 2023

Purpose

  • Upload artifact after build.
  • Another workflow will be added which will download this artifact and run tests.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@avidit avidit requested a review from sm6srw October 12, 2023 13:55
@QilongTang
Copy link
Contributor

@avidit Would you document where would the action upload to?

@avidit
Copy link
Contributor Author

avidit commented Oct 12, 2023

@avidit Would you document where would the action upload to?

Artifact can be accessed from the workflow summary page, At the bottom there will be a dedicated section for artifacts

By default, the artifacts and log files generated by workflows are retained for 90 days before they are automatically deleted.
https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#artifact-and-log-retention-policy

@avidit avidit requested a review from QilongTang October 12, 2023 15:00
@QilongTang
Copy link
Contributor

@avidit LGTM just want to confirm this publish and store service is free for open source repo correct?

@mjkkirschner
Copy link
Member

mjkkirschner commented Oct 12, 2023

Why do we need this? Don't we already have builds of net6 master? How does this relate to test complete tests?

ahh... I think I understand now, kind of interesting, I believe @zeusongit was already saving the builds in the github cache somewhere to use for the diff job. I guess it's not a big deal if we're not paying for it... ;)

@avidit
Copy link
Contributor Author

avidit commented Oct 12, 2023

I will look into action cache option as well. As far as understand it is free service.

@avidit avidit added the WIP label Oct 19, 2023
@avidit
Copy link
Contributor Author

avidit commented Oct 19, 2023

Cache would not be suitable option as there is no straight forward way to access the cache from a workflow of one repo from workflow in a different repo.
Updated PR

  • to add artifact retention for 3 days
  • add repository dispatch event to trigger workflow in DynamoTestCompleteTests repo

@avidit avidit removed the WIP label Oct 19, 2023
@QilongTang QilongTang merged commit 4194253 into DynamoDS:master Oct 20, 2023
17 of 18 checks passed
@avidit avidit deleted the feature/DYN-6292 branch October 20, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants