Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup net48 code #14489

Merged
merged 4 commits into from
Oct 19, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,6 @@
<PropertyGroup>
<NoWarn>MSB3539;CS1591;NUnit2005;NUnit2007;CS0618;CS0612;CS0672</NoWarn>
</PropertyGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net48' ">
<Reference Include="PresentationCore" />
<Reference Include="PresentationFramework" />
<Reference Include="System.Design" />
<Reference Include="System.Drawing" />
<Reference Include="System.Numerics" />
<Reference Include="System.Windows.Forms" />
<Reference Include="System.Xaml" />
<Reference Include="WindowsBase" />
<Reference Include="Microsoft.Practices.Prism">
<HintPath>..\..\extern\prism\Microsoft.Practices.Prism.dll</HintPath>
</Reference>
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\DynamoCoreWpf\DynamoCoreWpf.csproj">
<Project>{51BB6014-43F7-4F31-B8D3-E3C37EBEDAF4}</Project>
Expand Down
4 changes: 0 additions & 4 deletions src/DynamoCLI/DynamoCLI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
<UseVSHostingProcess>true</UseVSHostingProcess>
</PropertyGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net48' ">
<Reference Include="Microsoft.CSharp" />
<Reference Include="WindowsBase" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\DynamoApplications\DynamoApplications.csproj">
<Project>{aa782772-fe61-4226-baa4-eb529fa1646b}</Project>
Expand Down
4 changes: 0 additions & 4 deletions src/DynamoCoreWpf/Controls/ShortcutToolbar.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
using Dynamo.UI.Commands;
using Dynamo.ViewModels;
using Dynamo.Wpf.ViewModels.Core;
#if NETFRAMEWORK
using NotificationObject = Microsoft.Practices.Prism.ViewModel.NotificationObject;
#else
using NotificationObject = Dynamo.Core.NotificationObject;
#endif
using Greg.AuthProviders;
using System.Linq;
using System.Windows;
Expand Down
4 changes: 0 additions & 4 deletions src/DynamoCoreWpf/Controls/StartPage.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,7 @@
using Dynamo.Utilities;
using Dynamo.ViewModels;
using Dynamo.Wpf.Properties;
#if NETFRAMEWORK
using NotificationObject = Microsoft.Practices.Prism.ViewModel.NotificationObject;
#else
using NotificationObject = Dynamo.Core.NotificationObject;
#endif

namespace Dynamo.UI.Controls
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
using System;
using Dynamo.Graph.Nodes.CustomNodes;
using Dynamo.Wpf.ViewModels;
#if NETFRAMEWORK
using Microsoft.Practices.Prism.Commands;
#else
using Prism.Commands;
#endif
using DelegateCommand = Dynamo.UI.Commands.DelegateCommand;

namespace Dynamo.ViewModels
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,7 @@
using Dynamo.PackageManager;
using Dynamo.Utilities;
using Dynamo.Wpf.Properties;
#if NETFRAMEWORK
using NotificationObject = Microsoft.Practices.Prism.ViewModel.NotificationObject;
#else
using NotificationObject = Dynamo.Core.NotificationObject;
#endif

namespace Dynamo.ViewModels
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,7 @@
using System.IO;
using System.Windows;
using System.Windows.Input;
#if NETFRAMEWORK
using NotificationObject = Microsoft.Practices.Prism.ViewModel.NotificationObject;
#else
using NotificationObject = Dynamo.Core.NotificationObject;
#endif

namespace Dynamo.PackageManager.UI
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,7 @@
using Dynamo.Wpf.Utilities;
using Greg.AuthProviders;
using Greg.Responses;
#if NETFRAMEWORK
using Microsoft.Practices.Prism.Commands;
#else
using Prism.Commands;
#endif

namespace Dynamo.ViewModels
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
using Dynamo.ViewModels;
using Dynamo.Wpf.ViewModels;
using Greg.Responses;
#if NETFRAMEWORK
using Microsoft.Practices.Prism.Commands;
#else
using Prism.Commands;
#endif

namespace Dynamo.PackageManager.ViewModels
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,8 @@
using Lucene.Net.Index;
using Lucene.Net.QueryParsers.Classic;
using Lucene.Net.Search;
#if NETFRAMEWORK
using Microsoft.Practices.Prism.Commands;
using NotificationObject = Microsoft.Practices.Prism.ViewModel.NotificationObject;
#else
using Prism.Commands;
using NotificationObject = Dynamo.Core.NotificationObject;
#endif

namespace Dynamo.PackageManager
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
using Dynamo.Controls;
using Dynamo.ViewModels;
#if NETFRAMEWORK
using NotificationObject = Microsoft.Practices.Prism.ViewModel.NotificationObject;
#else
using NotificationObject = Dynamo.Core.NotificationObject;
#endif
using System.Collections.ObjectModel;

namespace Dynamo.PackageManager
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,8 @@
using Dynamo.PackageManager;
using Dynamo.Wpf.Properties;
using Dynamo.Wpf.Utilities;
#if NETFRAMEWORK
using NotificationObject = Microsoft.Practices.Prism.ViewModel.NotificationObject;
using Microsoft.Practices.Prism.Commands;
#else
using NotificationObject = Dynamo.Core.NotificationObject;
using Prism.Commands;
#endif

namespace Dynamo.ViewModels
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,8 @@
using PythonNodeModels;
using Double = System.Double;
using String = System.String;
#if NETFRAMEWORK
using NotificationObject = Microsoft.Practices.Prism.ViewModel.NotificationObject;
using Microsoft.Practices.Prism.Commands;
#else
using NotificationObject = Dynamo.Core.NotificationObject;
using Prism.Commands;
#endif

namespace Dynamo.PackageManager
{
Expand Down
4 changes: 0 additions & 4 deletions src/DynamoCoreWpf/ViewModels/Preview/WatchViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,7 @@
using Dynamo.Wpf.Properties;
using Dynamo.UI.Commands;
using Dynamo.Utilities;
#if NETFRAMEWORK
using NotificationObject = Microsoft.Practices.Prism.ViewModel.NotificationObject;
#else
using NotificationObject = Dynamo.Core.NotificationObject;
#endif
using Dynamo.Configuration;
using CoreNodeModels;

Expand Down
5 changes: 0 additions & 5 deletions src/DynamoCoreWpf/ViewModels/Search/BrowserItemViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,8 @@
using Dynamo.Search.SearchElements;
using Dynamo.ViewModels;
using Dynamo.Wpf.Extensions;
#if NETFRAMEWORK
using NotificationObject = Microsoft.Practices.Prism.ViewModel.NotificationObject;
using Microsoft.Practices.Prism.Commands;
#else
using NotificationObject = Dynamo.Core.NotificationObject;
using Prism.Commands;
#endif

namespace Dynamo.Wpf.ViewModels
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,7 @@
using Dynamo.Selection;
using Dynamo.ViewModels;
using FontAwesome5;
#if NETFRAMEWORK
using Microsoft.Practices.Prism.Commands;
#else
using Prism.Commands;
#endif

namespace Dynamo.Wpf.ViewModels
{
Expand Down
4 changes: 0 additions & 4 deletions src/DynamoCoreWpf/ViewModels/Search/SearchCategory.cs
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
using System.Windows.Input;
using Dynamo.UI.Commands;
#if NETFRAMEWORK
using NotificationObject = Microsoft.Practices.Prism.ViewModel.NotificationObject;
#else
using NotificationObject = Dynamo.Core.NotificationObject;
#endif

namespace Dynamo.Wpf.ViewModels
{
Expand Down
4 changes: 0 additions & 4 deletions src/DynamoCoreWpf/ViewModels/ViewModelBase.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
using System;
#if NETFRAMEWORK
using NotificationObject = Microsoft.Practices.Prism.ViewModel.NotificationObject;
#else
using NotificationObject = Dynamo.Core.NotificationObject;
#endif
using Newtonsoft.Json;

namespace Dynamo.ViewModels
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
using Dynamo.Engine.CodeCompletion;
using ICSharpCode.AvalonEdit.CodeCompletion;
using ICSharpCode.AvalonEdit.Editing;
#if NETFRAMEWORK
using NotificationObject = Microsoft.Practices.Prism.ViewModel.NotificationObject;
#else
using NotificationObject = Dynamo.Core.NotificationObject;
#endif

namespace Dynamo.UI
{
Expand Down
13 changes: 0 additions & 13 deletions src/DynamoManipulation/DynamoManipulation.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,6 @@
<RootNamespace>Dynamo.Manipulation</RootNamespace>
<AssemblyName>DynamoManipulation</AssemblyName>
</PropertyGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net48' ">
<Reference Include="PresentationCore" />
<Reference Include="PresentationFramework" />
<Reference Include="System" />
<Reference Include="System.Core" />
<Reference Include="System.Xaml" />
<Reference Include="System.Xml.Linq" />
<Reference Include="System.Data.DataSetExtensions" />
<Reference Include="Microsoft.CSharp" />
<Reference Include="System.Data" />
<Reference Include="System.Xml" />
<Reference Include="WindowsBase" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\DynamoCoreWpf\DynamoCoreWpf.csproj">
<Project>{51bb6014-43f7-4f31-b8d3-e3c37ebedaf4}</Project>
Expand Down
3 changes: 0 additions & 3 deletions src/DynamoPackages/DynamoPackages.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
<AssemblyName>DynamoPackages</AssemblyName>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net48' ">
<Reference Include="System.Configuration" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\DynamoCore\DynamoCore.csproj">
<Project>{7858fa8c-475f-4b8e-b468-1f8200778cf8}</Project>
Expand Down
12 changes: 0 additions & 12 deletions src/DynamoSandbox/DynamoSandbox.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,6 @@
<PropertyGroup>
<ApplicationIcon>logo_square_32x32.ico</ApplicationIcon>
</PropertyGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net48' ">
<Reference Include="PresentationCore" />
<Reference Include="PresentationFramework" />
<Reference Include="System.Configuration" />
<Reference Include="System.Xaml">
<RequiredTargetFramework>4.0</RequiredTargetFramework>
</Reference>
<Reference Include="WindowsBase" />
<Reference Include="Microsoft.Practices.Prism">
<HintPath>..\..\extern\prism\Microsoft.Practices.Prism.dll</HintPath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so can we remove this binary now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. Will do

</Reference>
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\DynamoApplications\DynamoApplications.csproj">
<Project>{aa782772-fe61-4226-baa4-eb529fa1646b}</Project>
Expand Down
10 changes: 0 additions & 10 deletions src/DynamoUtilities/DynamoUtilities.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,6 @@
<ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' ">
<PackageReference Include="System.Configuration.ConfigurationManager" Version="5.0.0" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net48' ">
<PackageReference Include="System.Collections.Immutable" Version="5.0.0">
<GeneratePathProperty>true</GeneratePathProperty>
<IncludeAssets>none</IncludeAssets>
</PackageReference>
<Reference Include="System.Collections.Immutable">
<HintPath>$(PkgSystem_Collections_Immutable)\lib\portable-net45+win8+wp8+wpa81\System.Collections.Immutable.dll</HintPath>
</Reference>
<Reference Include="System.Configuration" />
</ItemGroup>
<ItemGroup>
<Compile Update="Properties\Resources.Designer.cs">
<AutoGen>True</AutoGen>
Expand Down
2 changes: 1 addition & 1 deletion src/DynamoUtilities/ObservableHashSet.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Specialized;
using System.Collections.Generic;
using System.Linq;
Expand Down
6 changes: 0 additions & 6 deletions src/DynamoWPFCLI/DynamoWPFCLI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,6 @@
<RootNamespace>DynamoWPFCLI</RootNamespace>
<AssemblyName>DynamoWPFCLI</AssemblyName>
</PropertyGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net48' ">
<Reference Include="Microsoft.Practices.Prism">
<HintPath>..\..\extern\prism\Microsoft.Practices.Prism.dll</HintPath>
</Reference>
<Reference Include="WindowsBase" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
</ItemGroup>
Expand Down
4 changes: 0 additions & 4 deletions src/Engine/ProtoCore/ProtoCore.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@
<ProjectReference Include="..\..\Libraries\DesignScriptBuiltin\DesignScriptBuiltin.csproj" />
<ProjectReference Include="..\..\NodeServices\DynamoServices.csproj" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net48' ">
<Reference Include="Microsoft.CSharp" />
<Reference Include="System.Runtime.Serialization.Formatters.Soap" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' ">
<PackageReference Include="System.CodeDom" Version="6.0.0" />
<PackageReference Include="SoapFormatter" Version="1.0.11" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,6 @@
<AssemblyName>GraphMetadataViewExtension</AssemblyName>
<EnableDefaultPageItems>false</EnableDefaultPageItems>
</PropertyGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net48' ">
<Reference Include="PresentationCore" />
<Reference Include="PresentationFramework" />
<Reference Include="System.Xaml" />
<Reference Include="WindowsBase" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\DynamoCore\DynamoCore.csproj">
<Project>{7858fa8c-475f-4b8e-b468-1f8200778cf8}</Project>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,6 @@
<Name>DynamoCore</Name>
</ProjectReference>
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net48' ">
<Reference Include="PresentationCore" />
<Reference Include="PresentationFramework" />
<Reference Include="System.Windows.Forms" />
<Reference Include="System.Xaml" />
<Reference Include="System.Xml.Linq" />
<Reference Include="System.Data.DataSetExtensions" />
<Reference Include="Microsoft.CSharp" />
<Reference Include="System.Data" />
<Reference Include="System.Net.Http" />
<Reference Include="WindowsBase" />
</ItemGroup>
<ItemGroup>
<Page Include="Controls\ControlColorsAndBrushes.xaml">
<Generator>MSBuild:Compile</Generator>
Expand Down
5 changes: 0 additions & 5 deletions src/Libraries/CoreNodeModels/CoreNodeModels.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@
<ItemGroup>
<None Remove="CoreNodeModelsImages.resources" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net48' ">
<Reference Include="System.Web" />
<Reference Include="System.Windows" />
<Reference Include="System.Xaml" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<ProjectReference Include="..\..\DynamoCore\DynamoCore.csproj">
Expand Down
Loading
Loading