Fix deps.json #14515
Closed
Fix deps.json #14515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
FYI @mjkkirschner |
pinzart90
commented
Oct 24, 2023
| @@ -25,6 +25,9 @@ | |||
| <!--The System.Drawing package is only included in DynamoCore (and not in all projects that have image resources) for simplicity--> | |||
| <PackageReference Include="System.Drawing.Common" Version="6.0.0" /> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="System.Text.Json" Version="7.0.3" /> | |||
| </ItemGroup> | |||
There was a problem hiding this comment.
force syste,text.json vers 7
pinzart90
commented
Oct 24, 2023
| @@ -16,16 +16,16 @@ | |||
| <ProjectTypeGuids>{60dc8134-eba5-43b8-bcc9-bb4bc16c2548};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids> | |||
| <!-- Specify runtimeIdentifier to get around error NETSDK1047: Assets file 'obj\project.assets.json' doesn't have a target for 'net48/win7-x64'--> | |||
| <RuntimeIdentifier>win-x64</RuntimeIdentifier> | |||
| <GenerateDependencyFile>true</GenerateDependencyFile> | |||
There was a problem hiding this comment.
generate deps file only for sandbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
< Private >False< /Private > on Projects does not work well with deps.json files
I tried to generate a single deps.json file (for DynamoSandbox) and now it is picking up the System.Text.Json vers7 dll from the app dir
Bad news is that is seems fragile (when generating a single deps file).
Not sure this behaves in the revit context