Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for net8 #14661

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Fix tests for net8 #14661

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b05ae3
Update build.xml
sm6srw Nov 28, 2023
1a162cd
net8 test fixes
sm6srw Nov 29, 2023
fed09bd
Fix tests for net8
sm6srw Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/Libraries/DynamoPythonTests/CodeCompletionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ public void SharedCoreCanReturnCLRCompletionData()

Assert.IsTrue(completionList.Any());
Assert.IsTrue(completionList.Intersect(new[] { "Hashtable", "Queue", "Stack" }).Count() == 3);
#if NET8_0_OR_GREATER
Assert.IsTrue(completionData.Length == 32);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea what the extra element is?

#else
Assert.IsTrue(completionData.Length == 31);
#endif
}
}

Expand Down Expand Up @@ -236,7 +240,11 @@ public void CanImportSystemCollectionsLibraryAndGetCompletionData()

Assert.IsTrue(completionList.Any());
Assert.IsTrue(completionList.Intersect(new[] { "Hashtable", "Queue", "Stack" }).Count() == 3);
#if NET8_0_OR_GREATER
Assert.IsTrue(completionData.Length == 32);
#else
Assert.IsTrue(completionData.Length == 31);
#endif
}

[Test]
Expand Down
Loading