Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm-update-ui-cherrypick #14704

Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Dec 6, 2023

Purpose

Merging the last changes of the package manager PR has been difficult because of continuous test failures caused by the changes. This PR cherry-picks only the UI-related changes inside this #14655 (which was reverted here #14689)

This PR should not trigger any test issues, as the changes are only on the UI xaml side.

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • only UI related cherrypick which should not trigger any test issues

Reviewers

@reddyashish
@QilongTang

FYIs

@mjkkirschner

- only UI related cherrypick which should not trigger any test issues
@mjkkirschner
Copy link
Member

@dnenov please run this branch on the self serve on master-15.

@dnenov
Copy link
Collaborator Author

dnenov commented Dec 6, 2023

@dnenov please run this branch on the self-serve on master-15.

@mjkkirschner I have asked @reddyashish to help with this one, as my account does not let me post jobs it seems. If there is someone I can ask to let me do that, it would help lessen the impact on you guys, and speed up my work I think. Could you maybe tell me who I can approach with this request?

@reddyashish
Copy link
Contributor

@dnenov
Copy link
Collaborator Author

dnenov commented Dec 6, 2023

@reddyashish reddyashish merged commit 97761cd into DynamoDS:master Dec 6, 2023
21 checks passed
@dnenov dnenov mentioned this pull request Dec 7, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants