-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-6535 Search DynamoRevit #14750
DYN-6535 Search DynamoRevit #14750
Conversation
Re-implementing the Lucene Search Category Based in Dynamo 2.19.4 branch. Also I've removed the empty spaces from the SearchTerm so search results will match nodes with a specific name after the spaces are removed. I've removed the section of foreach (string s in searchTerm.Split(' ', '.')) due that now all the empty spaces will be removed from the SearchTerm.
@QilongTang After this changes this is GIF showing the search criteria used by the user, please let me know what you think (this is a draft PR). |
@QilongTang after checking all the search criteria cases used by the user I can say that two of them cannot be implemented easily, here are my comments. |
Hi Roberto, if I remember correctly, before removing space, search term with space in between will split the term into multiple keywords to search right? |
Fixing not passing test after adding the Category Based Search
When asking about the empty spaces to Sol described several use cases and also in Revit there are nodes Names with empty spaces then I will need to update my fix for supporting empty spaces. |
Thank you @RobertGlobant20 at this point, does it still make sense to target this PR to 2.19.4 branch? I know you mentioned it's best for us to cherry-pick some other Lucene related PRs first before continuing |
I will change the approach and also submit a new PR for the master branch (Dynamo 3.0) |
Purpose
Re-implementing the Lucene Search Category Based in Dynamo 2.19.4 branch for DynamoRevit. Also I've removed the empty spaces from the SearchTerm so search results will match nodes with a specific name after the spaces are removed. I've removed the section of foreach (string s in searchTerm.Split(' ', '.')) due that now all the empty spaces will be removed from the SearchTerm.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Re-implementing the Lucene Search Category Based in Dynamo 2.19.4 branch for DynamoRevit
Reviewers
@QilongTang
@reddyashish
FYIs