Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6535 Search DynamoRevit #14750

Closed
wants to merge 2 commits into from
Closed

DYN-6535 Search DynamoRevit #14750

wants to merge 2 commits into from

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Re-implementing the Lucene Search Category Based in Dynamo 2.19.4 branch for DynamoRevit. Also I've removed the empty spaces from the SearchTerm so search results will match nodes with a specific name after the spaces are removed. I've removed the section of foreach (string s in searchTerm.Split(' ', '.')) due that now all the empty spaces will be removed from the SearchTerm.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Re-implementing the Lucene Search Category Based in Dynamo 2.19.4 branch for DynamoRevit

Reviewers

@QilongTang
@reddyashish

FYIs

Re-implementing the Lucene Search Category Based in Dynamo 2.19.4 branch.
Also I've removed the empty spaces from the SearchTerm so search results will match nodes with a specific name after the spaces are removed.
I've removed the section of foreach (string s in searchTerm.Split(' ', '.')) due that now all the empty spaces will be removed from the SearchTerm.
@RobertGlobant20
Copy link
Contributor Author

@QilongTang After this changes this is GIF showing the search criteria used by the user, please let me know what you think (this is a draft PR).
SearchSetParameterRevit2024

@RobertGlobant20
Copy link
Contributor Author

@QilongTang after checking all the search criteria cases used by the user I can say that two of them cannot be implemented easily, here are my comments.
image

@QilongTang
Copy link
Contributor

Hi Roberto, if I remember correctly, before removing space, search term with space in between will split the term into multiple keywords to search right?

@RobertGlobant20
Copy link
Contributor Author

Hi Roberto, if I remember correctly, before removing space, search term with space in between will split the term into multiple keywords to search right?

yes, when the SearchTerm contain spaces in between the terms are splitted into multiple terms, doing a similar behavior when searching just for one word term but with less weight.
image

This is an example of the query created when searching for "list join".
image

It should be important to have some test cases when using spaces and see which should be the benefit.

Fixing not passing test after adding the Category Based Search
@RobertGlobant20
Copy link
Contributor Author

Hi Roberto, if I remember correctly, before removing space, search term with space in between will split the term into multiple keywords to search right?

When asking about the empty spaces to Sol described several use cases and also in Revit there are nodes Names with empty spaces then I will need to update my fix for supporting empty spaces.

@QilongTang
Copy link
Contributor

Thank you @RobertGlobant20 at this point, does it still make sense to target this PR to 2.19.4 branch? I know you mentioned it's best for us to cherry-pick some other Lucene related PRs first before continuing

@RobertGlobant20
Copy link
Contributor Author

I will change the approach and also submit a new PR for the master branch (Dynamo 3.0)

@RobertGlobant20 RobertGlobant20 deleted the DYN-6535-Search-DynamoRevit branch December 14, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants