-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-3844 Open Dynamo Template as new workspace #14871
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some comments
/// Present the open dialog and open the template that is selected. | ||
/// </summary> | ||
/// <param name="parameter"></param> | ||
private void ShowOpenTemplateDialog(object parameter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any way we can combine this with ShowOpenDialogAndOpenResult
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I thought about this but we need to call Open
function below with different tuple and use TemplatesDirectory
as start directory, currently there is nothing we can use to differentiate two workflows other than use different command for each menu item. I can try think about this more
<MenuItem Header="{x:Static p:Resources.DynamoViewFileMenuOpenTemplate}" | ||
Name="openTemplateMenuItem" | ||
Command="{Binding ShowOpenTemplateDialogCommand}" | ||
CommandParameter="Template" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeusongit I decided to use command param so we can distinguish if Dynamo is opening a template so we can reuse more file open code. We cant really use the same command because I think command and shortcut keys are 1:1 relationship and Open Template
need its own shortcut keys.
Merging this PR in to create the base of template function. |
Purpose
Introduce open by template function in Dynamo.
ToDo:
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of