Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, nice project!
I recently saw a design for a QR code that used different colors for certain control elements / patterns of a QR code and thought it might be a nice addition.
Functionally this PR doesn't change anything of the base implementations. It just replaces the
isStatic
parameter of thefillRect
function from:to expose the specific pattern type:
This allows for custom implementations of
EFPointStyle
to apply an individual styling to the control patterns of a QR code.Open to any suggestions, would be cool if we could add that to the project.. ^-*
Thanks, and happy #hacktoberfest 🥳