Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for el9 #6

Merged
merged 14 commits into from
Jun 4, 2024
Merged

Support for el9 #6

merged 14 commits into from
Jun 4, 2024

Conversation

andrea-manzi
Copy link

Summary

Support for el9, packages not available are conditionally excluded in spec file.


#4

@andrea-manzi andrea-manzi requested a review from gwarf as a code owner June 4, 2024 12:57
.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Maybe it would be better to use dnf everywhere for AlmaLinux9

ui.spec Outdated Show resolved Hide resolved
@gwarf
Copy link
Member

gwarf commented Jun 4, 2024

You can also already update the CHANGELOG file, as you added a new version to the spec

@andrea-manzi
Copy link
Author

@gwarf thanks for the suggestions, going to apply them now

andrea-manzi and others added 3 commits June 4, 2024 15:40
Co-authored-by: Baptiste Grenier <baptiste.grenier@egi.eu>
Co-authored-by: Baptiste Grenier <baptiste.grenier@egi.eu>
@andrea-manzi andrea-manzi requested a review from gwarf June 4, 2024 13:48
.github/workflows/build.yml Outdated Show resolved Hide resolved
CHANGELOG Show resolved Hide resolved
ui.spec Outdated Show resolved Hide resolved
Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry just a last few minor things

andrea-manzi and others added 3 commits June 4, 2024 16:00
Co-authored-by: Baptiste Grenier <baptiste.grenier@egi.eu>
Co-authored-by: Baptiste Grenier <baptiste.grenier@egi.eu>
Co-authored-by: Baptiste Grenier <baptiste.grenier@egi.eu>
@andrea-manzi andrea-manzi requested a review from gwarf June 4, 2024 14:12
Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gwarf gwarf merged commit 5dc9eeb into main Jun 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants