Clean up serializer/deserializer naming and prevent OOI issues #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, after 10 or so years, some test code started throwing NPEs after an unrelated changeset due to order-of-initial- isation issues in the JSON format objects. Where these are not macro-generated they're now `lazy vals`. Also rename a ton of the other reads/writes/format objects for consistency, with a leading '_' to make it clear they're auxilliary, often macro-generated companion object implicits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, after 10 or so years, some test code started throwing NPEs after an unrelated changeset due to order-of-initial- isation issues in the JSON format objects. Where these are not macro-generated they're now
lazy vals. Also rename a ton of the other reads/writes/format objects for consistency, with a leading '_' to make it clear they're auxilliary, often macro-generated companion object implicits.