Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix get_next_page_of_children function for User service #346

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix get_next_page_of_children function for User service #346

merged 1 commit into from
Aug 2, 2024

Conversation

jchen293
Copy link
Member

@jchen293 jchen293 commented Aug 1, 2024

Description

fix get_next_page_of_children function for User service

Testing

Update test, remove an invalid test assertion that will always raise KeyError

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@jchen293 jchen293 requested a review from a team August 1, 2024 21:38
@nwithan8 nwithan8 merged commit 0f0309f into master Aug 2, 2024
8 checks passed
@nwithan8 nwithan8 deleted the fix_user_get_next_page branch August 2, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

@nwithan8 nwithan8 nwithan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchen293 @nwithan8 @Justintime50