Tagging explosives #5434
Merged
Tagging explosives #5434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsPilgaard
added
Enhancement
Development
NielsPilgaard
requested changes
Dec 28, 2023
kubejs/server_scripts/enigmatica/kubejs/base/tags/items/enigmatica/explosives.js
Outdated
Show resolved
Hide resolved
kubejs/server_scripts/enigmatica/kubejs/base/tags/items/enigmatica/explosives.js
Outdated
Show resolved
Hide resolved
kubejs/server_scripts/enigmatica/kubejs/base/tags/items/enigmatica/explosives.js
Outdated
Show resolved
Hide resolved
kubejs/server_scripts/enigmatica/kubejs/base/tags/items/enigmatica/explosives.js
Outdated
Show resolved
Hide resolved
kubejs/server_scripts/enigmatica/kubejs/base/tags/items/enigmatica/explosives.js
Outdated
Show resolved
Hide resolved
kubejs/server_scripts/enigmatica/kubejs/base/tags/items/enigmatica/explosives.js
Outdated
Show resolved
Hide resolved
kubejs/server_scripts/enigmatica/kubejs/base/tags/items/enigmatica/explosives.js
Show resolved
Hide resolved
Co-authored-by: Niels Pilgaard Grøndahl <niels.pilgaard@hotmail.com>
firstRemove->removals thenAdd->additions for...of->foreach
NielsPilgaard
merged commit d0826e3
into
EnigmaticaModpacks:develop
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from here.
The main goal of this PR is to provide a infrastructure for effectively handling cases of "nested" tags, like
why:using/this/tag. E.g. when addingthermal:ice_tntinto#enlightened6:explosives/ice, it will also be added into#enlightened6:explosives.Explosives are just used as examples, such infrastructure will be most useful in
#forge:ingotstagging, but I didn't realize that when making this PR.And, I think, if this PR is merged, those filters in quest accepting
charged_snowball or ...can be replaced with tag filter