Consider even atomic loads as non-active writing (#882)

* Consider even atomic loads as non-active writing * Fix dso local nofree
EnzymeAD · Oct 5, 2022 · 6d95df2 · 6d95df2
1 parent 4671621
commit 6d95df2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/enzyme/Enzyme/ActivityAnalysis.cpp b/enzyme/Enzyme/ActivityAnalysis.cpp
@@ -2961,7 +2961,7 @@ bool ActivityAnalyzer::isValueInactiveFromUsers(TypeResults const &TR,
         }
         continue;
       }
-      if (!I->mayWriteToMemory()) {
+      if (!I->mayWriteToMemory() || isa<LoadInst>(I)) {
         if (TR.query(I)[{-1}].isIntegral()) {
           continue;
         }

diff --git a/enzyme/Enzyme/EnzymeLogic.cpp b/enzyme/Enzyme/EnzymeLogic.cpp
@@ -4854,9 +4854,9 @@ llvm::Function *EnzymeLogic::CreateNoFree(Function *F) {
     llvm_unreachable("unhandled, create no free");
   }
 
-  Function *NewF = Function::Create(F->getFunctionType(), F->getLinkage(),
+  Function *NewF = Function::Create(F->getFunctionType(),
+                                    Function::LinkageTypes::InternalLinkage,
                                     "nofree_" + F->getName(), F->getParent());
-  NewF->setLinkage(Function::LinkageTypes::InternalLinkage);
   NewF->setAttributes(F->getAttributes());
 #if LLVM_VERSION_MAJOR >= 9
   NewF->addAttribute(AttributeList::FunctionIndex,
@@ -4942,6 +4942,7 @@ llvm::Function *EnzymeLogic::CreateNoFree(Function *F) {
       }
     }
   }
+  NewF->setLinkage(Function::LinkageTypes::InternalLinkage);
 
   if (llvm::verifyFunction(*NewF, &llvm::errs())) {
     llvm::errs() << *F << "\n";