Recompute of constant global variables

EnzymeAD · May 17, 2021 · 777c96e · 777c96e
1 parent b3685b5
commit 777c96e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/enzyme/Enzyme/ActivityAnalysis.cpp b/enzyme/Enzyme/ActivityAnalysis.cpp
@@ -1206,7 +1206,7 @@ bool ActivityAnalyzer::isConstantValue(TypeResults &TR, Value *Val) {
                    << " potentiallyActiveLoad=" << potentiallyActiveLoad
                    << " potentialStore=" << potentialStore << "\n";
     if (potentiallyActiveLoad && potentialStore) {
-      activeLoadAndStore:;
+    activeLoadAndStore:;
       insertAllFrom(TR, *Hypothesis, Val);
       // TODO have insertall dependence on this
       if (TmpOrig != Val)

diff --git a/enzyme/Enzyme/EnzymeLogic.cpp b/enzyme/Enzyme/EnzymeLogic.cpp
@@ -191,10 +191,10 @@ struct CacheAnalysis {
         }
       } else if (isa<AllocaInst>(obj)) {
         // No change to modref if alloca
-      } else if (isa<GlobalVariable>(obj)) {
+      } else if (auto GV = dyn_cast<GlobalVariable>(obj)) {
         // In the absense of more fine-grained global info, assume object is
         // written to in a subseqent call unless this is "topLevel";
-        if (!topLevel) {
+        if (!topLevel && !GV->isConstant()) {
           mustcache = true;
         }
       } else if (auto sli = dyn_cast<LoadInst>(obj)) {