Generalize broadcast #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Companion PR to EnzymeAD/Enzyme#1952 Untested, but should enable arbitrary broadcast support (if all scalar functions are overloaded) |
mofeing
reviewed
Jul 1, 2024
src/Reactant.jl
Outdated
| @@ -429,7 +429,7 @@ function append_path(path, i) | |||
| return (path..., i) | |||
| end | |||
|
|
|||
| @inline function make_tracer(seen::IdDict, prev::RT, path, mode, data) where {RT} | |||
| @inline function make_tracer(seen::IdDict, prev::RT, path, mode, data; toscalar=false, tobatch=nothing) where {RT} | |||
There was a problem hiding this comment.
whether the tracer we create should automatically change all arrays to scalars, or scalars to arrays
mofeing
requested changes
Jul 6, 2024
src/overloads.jl
Outdated
| @@ -457,6 +457,95 @@ for (jlop, hloop) in ( | |||
| end | |||
| end | |||
|
|
|||
|
|
|||
| function elem_apply(f, args::VarArgs{Nargs}) | |||
There was a problem hiding this comment.
Need where here:
Suggested change
| function elem_apply(f, args::VarArgs{Nargs}) | |
| function elem_apply(f, args::VarArgs{Nargs}) where {Nargs} |
src/utils.jl
Outdated
| @@ -13,7 +13,7 @@ function apply(f, args...; kwargs...) | |||
| return f(args...; kwargs...) | |||
| end | |||
|
|
|||
| function make_mlir_fn(mod, f, args, kwargs, name="main", concretein=true) | |||
| function make_mlir_fn(mod, f, args, kwargs, name="main", concretein=true; toscalar=false) | |||
There was a problem hiding this comment.
Maybe we could turn name and concretein into kwargs?
Suggested change
| function make_mlir_fn(mod, f, args, kwargs, name="main", concretein=true; toscalar=false) | |
| function make_mlir_fn(mod, f, args, kwargs; name="main", concretein=true, toscalar=false) |
src/overloads.jl
Outdated
| function elem_apply(f, args::VarArgs{Nargs}) | ||
| primf = f.val | ||
|
|
||
| mod = MLIR.IR.module() |
There was a problem hiding this comment.
Suggested change
| mod = MLIR.IR.module() | |
| mod = MLIR.IR.mmodule() |
|
Line 2 in 5134fe0 |
avik-pal
reviewed
Jul 10, 2024
src/overloads.jl
Outdated
| OutShape = nothing | ||
| for (k, v) in seen_args | ||
| invmap[v] = k | ||
| OutShape size(k) |
There was a problem hiding this comment.
Suggested change
| OutShape size(k) | |
| OutShape = size(k) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.