This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Fix/allow video autoplay without click #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcottontensor
approved these changes
Oct 23, 2023
This was referenced Oct 23, 2023
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mcottontensor
added a commit
that referenced
this pull request
Oct 23, 2023
[UE5.2] Merge pull request #381 from New-Game-Plus/fix-video-autoplay
mcottontensor
added a commit
that referenced
this pull request
Oct 23, 2023
[UE5.3] Merge pull request #381 from New-Game-Plus/fix-video-autoplay
mcottontensor
added a commit
that referenced
this pull request
Oct 23, 2023
[UE5.4] Merge pull request #381 from New-Game-Plus/fix-video-autoplay
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Video is unable to autoplay (even when paused) due to attempting to play the audio first. Autoplaying muted videos should always work, according to Chrome/MDN docs
Solution
Autoplay the video, not the audio. Audio starts playing on frame click.
Documentation
N/A
Test Plan and Compatibility
We've been using this change in production at Odyssey for weeks, works well.