This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Update SignallingWebServer platform scripts to support Mac #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehb
reviewed
Oct 19, 2023
lukehb
suggested changes
Oct 19, 2023
lukehb
suggested changes
Oct 19, 2023
This was referenced Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Although PixelStreaming doesn't currently support Mac as a platform, this doesn't mean that the infrastructure can't be run on Mac (x86_64 / Arm64) devices.
Solution
This PR modifies the bash platform scripts to first check for the OS and architecture before grabbing the appropriate Node binaries.
Additionally, I've forked CoTurn and created binaries for each Mac architecture. This platform scripts now grab the correct binary for the machine's architecture as well.
Documentation
No documentation updates as we didn't explicitly state that we didn't support Mac.