Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Review changes #481

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Review changes #481

merged 7 commits into from
Jan 31, 2024

Conversation

mcottontensor
Copy link
Contributor

@mcottontensor mcottontensor commented Jan 31, 2024

  • Tidied up the tsc build process of the common library
  • Added WebSocketsTransportNJS implementation to common library for use with node.js applications using this lib.
  • Fixed issue with offer/answer handling in frontend lib. This was still working due to the way messages get constructed but the code was still incorrect.
  • Adding some comments to SignallingProtocol to explain what events are fired on what emitter
  • Moved SignallingProtocol from the WebSockets folder to the Protocol folder since it has nothing to do with websockets now.
  • Altered the signaling tester docker to use code in repo rather than published packages.

Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR itself looks great. As discussed, the failing test should use npm link instead of remote dependency, so it is testing latest source.

@mcottontensor mcottontensor merged commit 2246376 into EpicGames:UE5.5 Jan 31, 2024
1 check passed
@mcottontensor mcottontensor deleted the build_cleanup branch January 31, 2024 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants