Fix documentation for updateUserMemberships function, closes #1124 #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1132 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 177 177
Lines 3245 3245
Branches 550 550
=========================================
Hits 3245 3245
☔ View full report in Codecov by Sentry. |
gavinr-maps
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
This updates the sample code to reflect the actual option on type input https://developers.arcgis.com/arcgis-rest-js/api-reference/arcgis-rest-portal/IUpdateGroupUsersOptions#newMemberType - looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #1124. The documentation for the
updateUserMembershipsfunction was incorrect, suggesting the use ofadminsas a parameter, while the correct parameters areusersandnewMemberType.The comments in the code have been updated to reflect the correct usage of the function. This should ensure that the automatically generated documentation is now correct.