Skip to content

Commit

Permalink
[DONE] A11y for caption_maker (#982)
Browse files Browse the repository at this point in the history
* * Change TRANSCRIPTION_STT_SENTENCE_MAX_LENGTH default value to 2s
* Now caption-maker textareas are limited to 40 chars max per row, with max chars at 80
* When editing a caption/subtitle, the player auto-seek at related time
* add missing aria-hidden + aria-label on some button-icons
* Uniformize caption/subtitle naming
* Reorder CSS for code styling

* Add .po lang files

* Add missing JsDocs on caption_maker.js
+ Add .eslintrc.js to lint JS errors/warnings

* Add client Validation to caption maker for better ergonomy

* last minor corrections

* Add a minor code comment + rename some vars.
  • Loading branch information
Badatos authored Oct 16, 2023
1 parent 8c920c2 commit 8fdf7f0
Show file tree
Hide file tree
Showing 11 changed files with 631 additions and 357 deletions.
41 changes: 41 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
module.exports = {
"env": {
"browser": true,
"commonjs": true,
"es2021": true,
"node": true
},
"extends": "eslint:recommended",
"parserOptions": {
"ecmaVersion": "latest",
"sourceType": "script"
},
"rules": {
"indent": [
"error",
2,
{"SwitchCase": 1}
],
"linebreak-style": [
"error",
"unix"
],
"semi": [
"error",
"always",
],
/*"camelcase": ["warn", {"ignoreGlobals": true}],*/
/* First capital letter is reserved for "new" Objects. */
"new-cap": ["warn", { "capIsNew": true }]
},
/* functions and Objects that will not trigger a "not defined" error. */
"globals": {
"Cookies": "readonly",
"gettext": "readonly",
"interpolate": "readonly",
"bootstrap": "readonly",
"videojs": "readonly",
"send_form_data": "writable",
"showalert": "writable",
}
};
Loading

0 comments on commit 8fdf7f0

Please sign in to comment.