[DONE] Improve sort & menu order #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o AymericJak/improve_title_sort
AymericJak
changed the title
SebastienCozeDev
approved these changes
Nov 6, 2023
ptitloup
approved these changes
Nov 6, 2023
Badatos
approved these changes
Nov 6, 2023
| @@ -201,7 +202,7 @@ def sort_videos_list(videos_list, sort_field, sort_direction=""): | |||
|
|
|||
| Sorted by specific column name and ascending or descending direction | |||
| """ | |||
| if sort_field and sort_field in [ | |||
| if sort_field and sort_field in { | |||
There was a problem hiding this comment.
pourquoi un dict plutot qu'une liste ?
There was a problem hiding this comment.
Pour le parcours d'éléments, il est préférable d'utiliser un dictionnaire en python.
En python les dictionnaires sont implémenté avec une table de hachage.
Donc pour accéder à un élément, le temps est constant.
Pour une liste de taille n, la complexité est de O(n) --> on doit parcourir chaque éléments de celle-ci.
Alors que pour un dictionnaire, la complexité est de O(1).
There was a problem hiding this comment.
Merci pour l'info, c'est bon à savoir !! :)
vsabatie
pushed a commit
to vsabatie/Pod
that referenced
this pull request
Nov 22, 2023
* Improve video sort * Improve playlist sort * Fix titles * Reorganize menu buttons * Fix playlist test case * Improve playlist page tests * Add tests for playlists and flake8
vsabatie
pushed a commit
to vsabatie/Pod
that referenced
this pull request
Nov 23, 2023
* Improve video sort * Improve playlist sort * Fix titles * Reorganize menu buttons * Fix playlist test case * Improve playlist page tests * Add tests for playlists and flake8
vsabatie
pushed a commit
to vsabatie/Pod
that referenced
this pull request
Nov 23, 2023
* Improve video sort * Improve playlist sort * Fix titles * Reorganize menu buttons * Fix playlist test case * Improve playlist page tests * Add tests for playlists and flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tri des vidéos & amélioration du menu
Issue concernée : #950