[DONE] Fix event info display #1234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Badatos
approved these changes
Dec 9, 2024
| <div> | ||
| <a class="btn btn-link btn-sm" href="{% url 'videos:videos' %}?owner={{ event.owner.get_username }}" {% if request.GET.is_iframe %}target="_blank"{% endif %}> | ||
| <span class="pod-meta-title">{% trans 'Added by:' %}</span> | ||
| <a class="btn btn-link btn-sm px-0" href="{% url 'videos:videos' %}?owner={{ event.owner.get_username }}" {% if request.GET.is_iframe %}target="_blank" {% endif %} title="{% blocktrans with video_user_name=video.owner.get_username %}Show video list of user “{{ video_user_name }}”{% endblocktrans %}" data-bs-toggle="tooltip" data-bs-placement="bottom"> |
There was a problem hiding this comment.
utilise plutot event.owner sans le getUsername, car owner se charge d'afficher le username ou le fullname en fonction des parametres voulus
LoicBonavent
approved these changes
Dec 12, 2024
|
Loïc, tu voudrais que j'ôte la méthode get_username de l'objet User ? c'est ça ? parce qu'elle est encore appelée à plein d'endroits |
Non surtout pas ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reprend l'affichage des infos de l'évènement à l'image des infos d'une vidéo et affiche le max de viewer d'un live calculé par le heartbeat et stocké en base