-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An attempt at #401 - removing TX busywait #408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a way where the changes to the window size are communicated back to the watchers.
Otherwise this might work (I'm also not very familiar with low-level async), although something like Notify
might be a better fit as it only lets in one task at a time, which is already the case given the Mutex for the window size.
Dang, I wasn't testing it correctly in the first place, thanks for the fix! I'm also wondering whether |
Good point, that seems like the safer solution. Although that might cause unnecessary waking up of all writers. I wonder if dropping a writer should invoke |
This comment was marked as resolved.
This comment was marked as resolved.
- Guard against empty buffer - Fix tests not checking for panics - Add test_channel_window_size with multiple writers
@EpicEric is there anything you'd like to see added here? |
This looks good to me. |
No description provided.