Add boundary plane regression test #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made this by copying amr-wind regression tests and putting a nalu-wind box in there. Open to any tweaks that would make this make more sense as an actual case, rather than just something that accomplishes the required coverage. Just in case it gets reused as an example in the future. |
|
I like this idea. I am fine it being a dummy nalu-wind box. Thank you for doing this. |
|
@marchdf I guess I need an approval here |
marchdf
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to make sure this important capability is covered. The uniqueness of the file reads and using the overset solver make it prone to being accidentally broken.
Should follow after the merge of Exawind/amr-wind#1358