Skip to content

Commit

Permalink
fix: Correct apply_project in HttpRegistry (#161)
Browse files Browse the repository at this point in the history
  • Loading branch information
zabarn authored Dec 9, 2024
1 parent 1c1d1f0 commit 7ad16b7
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions sdk/python/feast/infra/registry/http.py
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,18 @@ def apply_project(
project: Project,
commit: bool = True,
): # type: ignore[return]
"""
We were not applying projects before the addition of the line below this comment.
When either validating features or trying to register them, the feature-store-feast-sdk would fail.
cli.py --> validate.py --> instantiating FeatureStore obj --> instantiating HttpRegistry obj --> apply_project()
No project was applied.
We then query the feature store registry and get back a 404 for the project.
Using apply_project_metadata(project.name) restores functionality.
Update this with correct implimentation for Project Objects later.
"""
self.apply_project_metadata(project.name)
return None

def delete_project(
Expand Down

0 comments on commit 7ad16b7

Please sign in to comment.