-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA] feat: Step 3 logic #52954
base: main
Are you sure you want to change the base?
[NO QA] feat: Step 3 logic #52954
Conversation
…-api-integration' into feat/step-3-logic # Conflicts: # src/libs/API/types.ts
…-api-integration' into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
…stack-internal/Expensify-App into feat/step-3-logic
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@@ -2263,11 +2263,14 @@ const translations = { | |||
whatsTheBusinessAddress: '¿Cuál es la dirección de la empresa?', | |||
whatsTheBusinessContactInformation: '¿Cuál es la información de contacto de la empresa?', | |||
whatsTheBusinessRegistrationNumber: '¿Cuál es el número de registro de la empresa?', | |||
whatsTheBusinessTaxIDEIN: '¿Cuál es el número de identificación fiscal/EIN/IVA/GST de la empresa?', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to get translations still - already requested
@hungvu193 Hey, I've marked it as ready for review because everything on FE is done (still need to get translations). It requires some changes on BE side that Ive mentioned before - #50905 (comment). Once it's done everything should start working properly without extra changes need on FE side so we can save some time by starting review now |
Cool. Thanks for letting me know 😁 |
Explanation of Change
Implements validation, API, navigation and other logic for step 3 in global reimbursements flow
Fixed Issues
$ #50905
PROPOSAL:
Tests
Change workspace currency to EUR, GBP, CAD or AUD
Enable workflows for the workspace
Open workflows
Try to connect a bank account
Go to the third step
Fill out all the forms and send data
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
android.web.mp4
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.safari.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4