Update smtherr model

FNNDSC · Feb 20, 2023 · 9c4005f · 9c4005f
1 parent df8766c
commit 9c4005f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -48,8 +48,7 @@ Moreover, `sphere_mesh` guarantees a spherical topology.
 We developed a model which predicts the number of `adapt_object_mesh` smoothing iterations necessary, given a desired smoothness error threshold.
 The model was created from the experiment described here:
 
-- https://github.com/FNNDSC/voxelation-error-datalad/blob/90fd86aa2e1a280cbda6a210c802236e34b76457/README.md
-- https://github.com/FNNDSC/voxelation-error-datalad/blob/90fd86aa2e1a280cbda6a210c802236e34b76457/5_notebook/taubin_vs_mean_smtherr.ipynb
+- https://github.com/FNNDSC/smoothness-error-datalad/blob/94b414dc019ee236485abb8e0af646fca1219dac/5_notebook/smoothing_vs_mean_smtherr.ipynb
 
 ## Pipeline
 

diff --git a/extract_cp/predict_smth.py b/extract_cp/predict_smth.py
@@ -7,9 +7,9 @@
 # TODO RERUN THE MODEL USING A TIGHTER STARTING SURFACE
 # modeled MAX_SMTHERR is much smaller than actuals
 
-A = 3.63462484
-H = -9.62391412
-K = 0.05865665
+A = 10.93738233
+H = -14.53134114
+K = 0.01999569
 
 
 def predict_aom(current: float, target: float, max_iters: int = 200) -> int:

diff --git a/setup.py b/setup.py
@@ -2,7 +2,7 @@
 
 setup(
     name='extract_cp',
-    version='2.0.0',
+    version='2.0.1',
     description='Fetal brain MRI CP surface extraction using CIVET marching-cubes',
     author='Jennings Zhang',
     author_email='Jennings.Zhang@childrens.harvard.edu',

diff --git a/tests/test_predict_smth.py b/tests/test_predict_smth.py
@@ -14,7 +14,7 @@ def test_no_smoothing_needed():
 
 
 def test_across_horizontal_asymptote():
-    assert predict_aom(0.30, 0.001, max_iters=99) > 90
+    assert predict_aom(0.30, 0.00001, max_iters=99) > 50
 
 
 def test_across_vertical_asymptote():